ref(cells): Update org creation testutils to pass cell kwarg#111819
Merged
ref(cells): Update org creation testutils to pass cell kwarg#111819
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Renamed parameter breaks all existing callers using
region=- I restored backward compatibility by consuming
regionfromkwargsand mapping it tocellwhencellis not explicitly provided, preventing invalid ORM kwargs and preserving caller intent.
- I restored backward compatibility by consuming
Or push these changes by commenting:
@cursor push 551254e2b7
Preview (551254e2b7)
diff --git a/src/sentry/testutils/factories.py b/src/sentry/testutils/factories.py
--- a/src/sentry/testutils/factories.py
+++ b/src/sentry/testutils/factories.py
@@ -382,6 +382,11 @@
if not name:
name = petname.generate(2, " ", letters=10).title()
+ # Backwards compatibility for callers still passing region=.
+ region = kwargs.pop("region", None)
+ if cell is None and region is not None:
+ cell = region
+
with contextlib.ExitStack() as ctx:
if cell is None or SiloMode.get_current_mode() == SiloMode.MONOLITH:
cell_name = get_local_cell().nameThis Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Contributor
Backend Test FailuresFailures on
|
Contributor
Backend Test FailuresFailures on
|
markstory
approved these changes
Mar 31, 2026
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Test failures look relevant.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Backend Test FailuresFailures on
|
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.