Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| > = hasPageFrame | ||
| ? layout === 'mobile' | ||
| ? {top: '0', right: '0'} | ||
| : {top: '0', right: '0'} |
Contributor
There was a problem hiding this comment.
Redundant ternary produces identical values for both branches
Medium Severity
When hasPageFrame is true, the layout === 'mobile' ternary on lines 324–326 returns {top: '0', right: '0'} for both branches, making the condition dead code. Given that the non-hasPageFrame path does differentiate between mobile (left: '11px', offset top) and desktop (top: '0', right: '0'), this looks like a copy-paste error where the hasPageFrame + mobile case was not given its intended distinct positioning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke with our change to the new indicators, so I'm updating each element's location and the button overflow accordingly