fix(dashboards): Stop passing list page query params to dashboard details#111815
Merged
DominikB2014 merged 1 commit intomasterfrom Mar 31, 2026
Conversation
…ails The dashboards list page was forwarding its query parameters (sort, filter, search) to dashboard detail links. This caused unintended params to appear in dashboard detail URLs when navigating from the list page. Remove query param forwarding from DashboardGrid card links, DashboardTable name links, and the onCreate/loadDashboard/onPreview navigation functions in the manage index. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
edwardgou-sentry
approved these changes
Mar 30, 2026
DominikB2014
deleted the
dominikbuszowiecki/dain-1432-nextjs-rage-and-dead-click-link-is-broken
branch
dashed
pushed a commit
that referenced
this pull request
Apr 1, 2026
…ails (#111815) The dashboards list page was forwarding its query parameters (`sort`, `filter`, `query`) through to dashboard detail page links. When navigating from the list to a specific dashboard, these list-page-specific params would appear in the detail URL, which could interfere with the dashboard's own filter handling (e.g., saved global filters). These query params aren't really used in dashboard details, and has potential to mess up the state of certain widgets that might confuse these params Removes query param forwarding from: - `DashboardGrid` card links - `DashboardTable` name links - `onCreate`, `loadDashboard`, and `onPreview` navigation in the manage index Fixes DAIN-1432 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboards list page was forwarding its query parameters (
sort,filter,query) through to dashboard detail page links. When navigating from the list to a specific dashboard, these list-page-specific params would appear in the detail URL, which could interfere with the dashboard's own filter handling (e.g., saved global filters).These query params aren't really used in dashboard details, and has potential to mess up the state of certain widgets that might confuse these params
Removes query param forwarding from:
DashboardGridcard linksDashboardTablename linksonCreate,loadDashboard, andonPreviewnavigation in the manage indexFixes DAIN-1432