fix(preprod): Post NEUTRAL status check when all artifacts are skipped#111811
Open
fix(preprod): Post NEUTRAL status check when all artifacts are skipped#111811
Conversation
When all artifacts for a commit are filtered/skipped by project settings, the status check task returned early without updating any previously posted IN_PROGRESS check on GitHub. This left checks stuck as in_progress forever. Now posts a NEUTRAL completed check with a "Size analysis skipped" message and a link to configure status check rules, matching the existing pattern for the no-quota case. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
NicoHinderling
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all artifacts for a commit are filtered/skipped by project settings, the
status check task returned early without updating any previously posted
IN_PROGRESS check on GitHub. This left checks stuck as
in_progressforever.Confirmed in production: artifact uploads would initially post an IN_PROGRESS
check (before the filter decision), then a subsequent task invocation would see
all artifacts as SKIPPED and hit the early return at
tasks.py:256-261— neverupdating the check to a terminal state.
Now the
all_skippedbranch posts a NEUTRAL completed check with a "Sizeanalysis skipped" message and a link to configure status check rules, matching
the existing pattern for the no-quota case.