Skip to content

ref(issue-ownership): allow all assignments when open membership is on #111809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cvxluo wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −14
Draft

ref(issue-ownership): allow all assignments when open membership is on #111809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5630848
feat(assignments): allow assigning any org member when open membershi…
cvxluo Mar 30, 2026
3eb8f39
feat(assignments): allow assigning any org team when open membership …
cvxluo Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions src/sentry/api/helpers/group_index/validators/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,21 +83,27 @@ class GroupValidator(serializers.Serializer[Group]):
snoozeDuration = serializers.IntegerField(allow_null=True)

def validate_assignedTo(self, value: Actor) -> Actor:
if (
value
and value.is_user
and not self.context["project"].member_set.filter(user_id=value.id).exists()
):
raise serializers.ValidationError("Cannot assign to non-team member")
if value and value.is_user:
organization = self.context["organization"]
project = self.context["project"]
# With open membership, any org member can be assigned since they
# can join any team (and thus gain project access) at will.
if organization.flags.allow_joinleave:
if not organization.member_set.filter(user_id=value.id).exists():
raise serializers.ValidationError("Cannot assign to non-organization member")
elif not project.member_set.filter(user_id=value.id).exists():
raise serializers.ValidationError("Cannot assign to non-team member")

if (
value
and value.is_team
and not self.context["project"].teams.filter(id=value.id).exists()
):
raise serializers.ValidationError(
"Cannot assign to a team without access to the project"
)
if value and value.is_team:
organization = self.context["organization"]
project = self.context["project"]
# With open membership, allow assigning any org team. The team's
# org membership is already validated by ActorField.to_internal_value.
if not organization.flags.allow_joinleave:
if not project.teams.filter(id=value.id).exists():
raise serializers.ValidationError(
"Cannot assign to a team without access to the project"
)

return value

Expand Down
Loading