fix(grouping): Fix kitchen time regex bugs#111807
Merged
lobsterkatie merged 5 commits intomasterfrom Mar 30, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
lobsterkatie
force-pushed
the
kmclb-add-ip-and-kitchen-time-test-cases
branch
from
0d586bb to
15a80f2
Compare
lobsterkatie
force-pushed
the
kmclb-fix-more-kitchen-time-regex-bugs
branch
from
741a1d6 to
46169bb
Compare
wedamija
approved these changes
Mar 30, 2026
Base automatically changed from
kmclb-add-ip-and-kitchen-time-test-cases
to
master
March 30, 2026 22:41
lobsterkatie
force-pushed
the
kmclb-fix-more-kitchen-time-regex-bugs
branch
from
46169bb to
b1e5e33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs with our "kitchen" (digital clock) time regex.
Allow 24-hour time to include leading zeros.
Restrict allowable values in each spot (no more 3-digit hours, no more minutes and seconds > 59, etc.).