Skip to content

chore(aci): All create monitor buttons should like to type selection#111801

Open
malwilley wants to merge 2 commits intomasterfrom
malwilley/fix-create-monitor-btn
Open

chore(aci): All create monitor buttons should like to type selection#111801
malwilley wants to merge 2 commits intomasterfrom
malwilley/fix-create-monitor-btn

Conversation

@malwilley
Copy link
Copy Markdown
Member

Closes ISWF-2215

"Create Monitor" buttons should always link to the initial type selection page. We made this link to the actual form on the type-specific pages after user feedback, but we now believe that the original experience was more consistent and leads to less confusion overall.

@malwilley malwilley requested a review from a team as a code owner March 30, 2026 17:47
@linear-code
Copy link
Copy Markdown

linear-code bot commented Mar 30, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 30, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Unused export makeMonitorCreateSettingsPathname after removing its only consumer
    • Removed the unused makeMonitorCreateSettingsPathname function from pathnames.tsx since it had no remaining consumers after the PR removed its only import.

Create PR

Or push these changes by commenting:

@cursor push fb4497098e
Preview (fb4497098e)
diff --git a/static/app/views/detectors/pathnames.tsx b/static/app/views/detectors/pathnames.tsx
--- a/static/app/views/detectors/pathnames.tsx
+++ b/static/app/views/detectors/pathnames.tsx
@@ -23,10 +23,6 @@
   return normalizeUrl(`${makeMonitorBasePathname(orgSlug)}new/`);
 };
 
-export const makeMonitorCreateSettingsPathname = (orgSlug: string) => {
-  return normalizeUrl(`${makeMonitorBasePathname(orgSlug)}new/settings/`);
-};
-
 export const makeMonitorEditPathname = (orgSlug: string, monitorId: string) => {
   return normalizeUrl(`${makeMonitorBasePathname(orgSlug)}${monitorId}/edit/`);
 };

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant