chore(aci): All create monitor buttons should like to type selection#111801
Open
chore(aci): All create monitor buttons should like to type selection#111801
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Unused export
makeMonitorCreateSettingsPathnameafter removing its only consumer- Removed the unused
makeMonitorCreateSettingsPathnamefunction from pathnames.tsx since it had no remaining consumers after the PR removed its only import.
- Removed the unused
Or push these changes by commenting:
@cursor push fb4497098e
Preview (fb4497098e)
diff --git a/static/app/views/detectors/pathnames.tsx b/static/app/views/detectors/pathnames.tsx
--- a/static/app/views/detectors/pathnames.tsx
+++ b/static/app/views/detectors/pathnames.tsx
@@ -23,10 +23,6 @@
return normalizeUrl(`${makeMonitorBasePathname(orgSlug)}new/`);
};
-export const makeMonitorCreateSettingsPathname = (orgSlug: string) => {
- return normalizeUrl(`${makeMonitorBasePathname(orgSlug)}new/settings/`);
-};
-
export const makeMonitorEditPathname = (orgSlug: string, monitorId: string) => {
return normalizeUrl(`${makeMonitorBasePathname(orgSlug)}${monitorId}/edit/`);
};This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes ISWF-2215
"Create Monitor" buttons should always link to the initial type selection page. We made this link to the actual form on the type-specific pages after user feedback, but we now believe that the original experience was more consistent and leads to less confusion overall.