fix(dashboards): numeric literal not registering in equations builder#111793
Merged
nikkikapadia merged 2 commits intomasterfrom Mar 31, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
jameskeane
approved these changes
Mar 30, 2026
nsdeschenes
approved these changes
Mar 31, 2026
…ats-100-as-1-inconsistently
nikkikapadia
deleted the
nikkikapadia/dain-1261-equation-editor-treats-100-as-1-inconsistently
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there was an issue in dashboards where a numeric literal in the equation would not fully register and only the first character would register. This is because the number was only committed on enter. We want the number to be committed on blur as well because only committing on enter is not intuitive. This left some widgets to not be saved properly (which sucks). Ticket will be linked by linear for more context.