Open
Conversation
Co-Authored-By: bmckerry <110857332+bmckerry@users.noreply.github.com>
github-actions
bot
added
the
Scope: Backend
bmckerry
approved these changes
Mar 30, 2026
bmckerry
force-pushed
the
bot/bump-version/sentry-arroyo/2.38.5
branch
from
1232a4c to
2203c57
Compare
bmckerry
reviewed
Mar 31, 2026
| from confluent_kafka.admin import AdminClient, PartitionMetadata | ||
| from confluent_kafka.admin import ( | ||
| AdminClient, | ||
| PartitionMetadata, # type: ignore[attr-defined] |
Member
There was a problem hiding this comment.
confluent_kafka doesn't explicitly export PartitionMetadata for some reason
| self.callback, committable=message.committable, timestamp=message.timestamp | ||
| ), | ||
| headers=message.payload.headers, | ||
| headers=message.payload.headers, # type: ignore[arg-type] |
Member
There was a problem hiding this comment.
message.payload.headers is Arroyo's Headers type, while the arg expects confluent_kafka's HeadersType
Comment on lines
-76
to
+77
| all_consumers: MutableMapping[str, Consumer | None] = { | ||
| all_consumers: MutableMapping[str, StreamProcessor | None] = { |
Member
There was a problem hiding this comment.
Typing here was always wrong, all_consumers values are StreamProcessors not Consumers
bmckerry
force-pushed
the
bot/bump-version/sentry-arroyo/2.38.5
branch
from
2203c57 to
9efbc5d
Compare
bmckerry
force-pushed
the
bot/bump-version/sentry-arroyo/2.38.5
branch
from
9efbc5d to
f7935c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: bmckerry 110857332+bmckerry@users.noreply.github.com