Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Serializer/AbstractSerializer.php
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ protected function serializeRecursively($value, int $_depth = 0)
return $this->formatDate($value);
}

if ($value instanceof \UnitEnum) {
return $this->serializeValue($value);
}

if ($this->serializeAllObjects || ($value instanceof \stdClass)) {
return $this->serializeObject($value, $_depth);
}
Expand Down Expand Up @@ -247,8 +251,13 @@ protected function serializeValue($value)

if ($value instanceof \UnitEnum) {
$reflection = new \ReflectionObject($value);
$enumValue = $reflection->getName() . '::' . $value->name;

if ($value instanceof \BackedEnum) {
return 'Enum ' . $enumValue . '(' . $value->value . ')';
}

return 'Enum ' . $reflection->getName() . '::' . $value->name;
return 'Enum ' . $enumValue;
}

if (\is_object($value)) {
Expand Down
50 changes: 50 additions & 0 deletions tests/Serializer/AbstractSerializerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,56 @@ public function testEnumsAreNames(): void
$this->assertSame('Enum Sentry\Tests\Serializer\SerializerTestEnum::CASE_NAME', $result);
}

/**
* @requires PHP >= 8.1
*/
public function testBackedEnumsIncludeValue(): void
{
$serializer = $this->createSerializer();
$input = SerializerTestBackedEnum::CASE_NAME;
$result = $this->invokeSerialization($serializer, $input);

$this->assertSame('Enum Sentry\Tests\Serializer\SerializerTestBackedEnum::CASE_NAME(case_value)', $result);
}

/**
* @requires PHP >= 8.1
*
* @dataProvider serializeAllObjectsDataProvider
*/
public function testEnumsAreNotSerializedAsObjects(bool $serializeAllObjects): void
{
$serializer = $this->createSerializer();

if ($serializeAllObjects) {
$serializer->setSerializeAllObjects(true);
}

$input = SerializerTestEnum::CASE_NAME;
$result = $this->invokeSerialization($serializer, $input);

$this->assertSame('Enum Sentry\Tests\Serializer\SerializerTestEnum::CASE_NAME', $result);
}

/**
* @requires PHP >= 8.1
*
* @dataProvider serializeAllObjectsDataProvider
*/
public function testBackedEnumsAreNotSerializedAsObjects(bool $serializeAllObjects): void
{
$serializer = $this->createSerializer();

if ($serializeAllObjects) {
$serializer->setSerializeAllObjects(true);
}

$input = SerializerTestBackedEnum::CASE_NAME;
$result = $this->invokeSerialization($serializer, $input);

$this->assertSame('Enum Sentry\Tests\Serializer\SerializerTestBackedEnum::CASE_NAME(case_value)', $result);
}

public static function objectsWithIdPropertyDataProvider(): array
{
return [
Expand Down
10 changes: 10 additions & 0 deletions tests/Serializer/SerializerTestBackedEnum.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

declare(strict_types=1);

namespace Sentry\Tests\Serializer;

enum SerializerTestBackedEnum: string
{
case CASE_NAME = 'case_value';
}
Loading