feat: add lazy init to batcher#1611
Closed
JoshuaMoelans wants to merge 3 commits intojoshua/chore/set_default_metrics_truefrom
Closed
feat: add lazy init to batcher#1611JoshuaMoelans wants to merge 3 commits intojoshua/chore/set_default_metrics_truefrom
JoshuaMoelans wants to merge 3 commits intojoshua/chore/set_default_metrics_truefrom
Conversation
- to avoid always running batcher thread even if no metrics are sent - does add single atomic fetch on each enqueue (TBD)
|
…close Rename STOPPED → IDLE to clarify it means "not yet started" (retryable), and introduce SHUT_DOWN as a terminal state that start_thread refuses to transition from. This closes a race where a concurrent enqueue could respawn the batcher thread after sentry_close() had already torn down the transport. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The spawned batcher thread received a raw pointer without its own refcount, and shutdown could join a zeroed-out thread handle when start_thread was between the CAS and pthread_create. - Add thread refcount: increment before spawn, release on thread exit - Add thread_spawned atomic flag so shutdown waits for a valid handle - Use CAS on spawn failure to avoid overwriting SHUT_DOWN state Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
possibly part of #1609
#skip-changelog