ref(logs): extract attribute helpers for metrics #1497
Merged
+147
−128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracts attribute helper functions from the logs implementation to make them reusable for the upcoming metrics feature.
Changes:
sentry__value_add_attribute()tosentry_value.cfor adding typed attributes to telemetry datasentry__scope_apply_attributes()tosentry_scope.cfor applying user/OS/trace contextsentry__apply_attributes()tosentry_core.cas the main entry point combining scope and options dataThis is a pure refactoring with no behavioral changes - the logs feature continues to work exactly as before.
Test plan
Relates to #1453