Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Jan 28, 2026

Summary

Extracts attribute helper functions from the logs implementation to make them reusable for the upcoming metrics feature.

Changes:

  • Extract sentry__value_add_attribute() to sentry_value.c for adding typed attributes to telemetry data
  • Extract sentry__scope_apply_attributes() to sentry_scope.c for applying user/OS/trace context
  • Add sentry__apply_attributes() to sentry_core.c as the main entry point combining scope and options data

This is a pure refactoring with no behavioral changes - the logs feature continues to work exactly as before.

Test plan

  • Existing logs integration tests pass
  • No new public API changes

Relates to #1453

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

jpnurmi added a commit that referenced this pull request Jan 29, 2026
@jpnurmi jpnurmi mentioned this pull request Jan 29, 2026
4 tasks
@jpnurmi jpnurmi merged commit bfe0ba0 into master Jan 29, 2026
70 of 73 checks passed
@jpnurmi jpnurmi deleted the jpnurmi/ref/attributes branch January 29, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants