ref(logs): extract reusable batcher for metrics #1495
Merged
+465
−392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sentry_logs.cinto a reusablesentry_batchermoduleChanges
New files:
src/sentry_batcher.h- Batcher types and API declarationssrc/sentry_batcher.c- Batcher implementationKey features of the batcher:
batch_funccallback for telemetry-specific envelope creationsentry__batcher_wait_for_thread_startup()for avoiding race conditionsAPI:
Usage example (from sentry_logs.c):
Test plan
Relates to #1453