ref(crashpad): pass predefined report ID #1488
Open
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-report-id
branch
4 times, most recently
from
96b9632 to
0dd654c
Compare
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
Add wait_for_file helper to handle the race condition where crashpad moves the minidump file asynchronously after the HTTP upload completes, so the file is not guaranteed to be present immediately after waiting for the HTTP request. Co-Authored-By: Claude Opus 4.5 <[email protected]>
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-report-id
branch
from
7007c87 to
89d9958
Compare
Collaborator
Author
|
Side-note: to be merged after the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation step for offline caching. It passes a
--report-id=<uuid>command-line argument to the crashpad handler to make crashpad use predefined report IDs instead of generating random IDs.This eliminates a discrepancy between sentry-native and crashpad by allowing both operate on the same event/report IDs. Since #1319, sentry-native pre-generates event IDs (stored in
__sentry-event) on startup, and this change makes crashpad use the same ID as report ID. This way, sentry-native's crashpad backend can maintain sentry-specific event-related state without having to communicate everything to crashpad, which makes it easier to convert completed crashpad reports back to sentry envelopes for backend-agnostic offline caching.See also: