chore: Remove unused tsconfig-template folder#20067
Merged
Conversation
mydea
requested review from
JPeer264 and
nicohrubec
and removed request for
a team
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Core
Other
🤖 This preview updates automatically when you update the PR. |
andreiborza
approved these changes
Apr 1, 2026
Comment on lines
-1
to
-7
| # `tsconfig` Templates | ||
|
|
||
| Every package should get its own copy of the three files in this directory and the one in `test/` (which should go in an | ||
| analogous spot in the package). Package-specific options should go in `tsconfig.json` and test-specific options in | ||
| `tsconfig.test.json`. The `types` file shouldn't need to be modified, and only exists because tsconfigs don't support | ||
| multiple inheritance. The same goes for the file in `test/`, which only exists because VSCode only knows to look for a | ||
| file named (exactly) `tsconfig.json`. |
Member
There was a problem hiding this comment.
l: Maybe we can keep this around somewhere? Maybe https://github.com/getsentry/sentry-javascript/blob/develop/docs/creating-a-new-sdk.md?
Member
Author
There was a problem hiding this comment.
I'll add a section to this!
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
Apr 1, 2026
JPeer264
approved these changes
Apr 1, 2026
andreiborza
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this folder and have never used it, and as far as I am aware others have neither - usually folks just copy these files from another existing package.