Skip to content

chore(nuxt): Pin nuxt-nightly canary to working version #19950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
logaretm wants to merge 1 commit into from
Closed

chore(nuxt): Pin nuxt-nightly canary to working version #19950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/nuxt-3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"clean": "npx nuxi cleanup",
"test": "playwright test",
"test:build": "pnpm install && pnpm build",
"test:build-canary": "pnpm add nuxt@npm:nuxt-nightly@3x && pnpm add nitropack@npm:nitropack-nightly@latest && pnpm install --force && pnpm build",
"test:build-canary": "pnpm add nuxt@npm:nuxt-nightly@3.21.3-29561591.46bcd990 && pnpm install --force && pnpm build",
Copy link
Member

@s1gr1d s1gr1d Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you wrote in the description that Nuxt v3 is incompatible with Nitro v2: No, Nuxt v3 is using Nitro v2, so it should still work to keep the nightly version of nitropack here.

I checked what is used now and the canary test shows this output:
Nuxt 3.21.3-29561591.46bcd990 (with Nitro 2.13.2, Vite 7.3.1 and Vue 3.5.30)

Sometimes features of nuxt-nightly depend on nitropack-nightly, that's why there's this extra adding of this dependency.

Copy link
Member

@s1gr1d s1gr1d Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But as this is an upstream issue that Nitro is going to fix soon, I think it's also fine to just keep the test as it is right now (nightlies are not blocking CI) and wait for it to resolve.

Otherwise we would need to create another PR switching it back to the latest (or 3x version).

Copy link
Member Author

@logaretm logaretm Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, I can put this as a draft then and close it if it gets fixed soon.

"test:assert": "pnpm test"
},
"dependencies": {
Expand Down
Loading