chore: Ensure appropriate Maven references for net10-android targets #4876
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescrosswell
commented
Jan 27, 2026
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="CommunityToolkit.Mvvm" Version="8.3.2"/> | ||
| <PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.0"/> |
Collaborator
Author
There was a problem hiding this comment.
This bumps to the latest version of CommunityToolkit.Mvvm... typically we target the oldest version possible but CommunityToolkit.Mvvm has shared Java dependencies with Maui and also with some of the transitive dependencies we take through the Sentry SDK for Java. So for this particular integration, our approach has been to keep it as up to date as possible (as long as that isn't incompatible with either the versions of net-android we target or the dependencies we get via the Sentry SDK for Java).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4876 +/- ##
==========================================
+ Coverage 73.84% 73.87% +0.02%
==========================================
Files 483 483
Lines 17578 17578
Branches 3464 3464
==========================================
+ Hits 12980 12985 +5
+ Misses 3742 3740 -2
+ Partials 856 853 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jamescrosswell
force-pushed
the
maven-references-net10
branch
from
9b405dd to
cb41e0c
Compare
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Test
Other
Other
🤖 This preview updates automatically when you update the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4802:
Basically done here:
sentry-dotnet/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj
Lines 48 to 61 in 9b405dd
Note
I tried bumping
Xamarin.AndroidX.Lifecycle.Common.Java8andXamarin.AndroidX.Lifecycle.Processto2.10.0but that gives us dependency conflicts in our Sentry.Maui package. It might be possible with a bit of sleuthing to work out where those come from (would have to be from the<UseMaui>true</UseMaui>include... so somewhere in the MS target files) but I think the fact that it breaks our builds is evidence enough that it's not the right version to reference so I left it at2.9.2.1.