Bump API schema to ee34d268#17241
Merged
sentry-api-schema-updater[bot] merged 1 commit intomasterfrom Apr 2, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| // SENTRY_API_SCHEMA_SHA is used in the sentry-docs GHA workflow in getsentry/sentry-api-schema. | ||
| // DO NOT change variable name unless you change it in the sentry-docs GHA workflow in getsentry/sentry-api-schema. | ||
| const SENTRY_API_SCHEMA_SHA = 'edac98f0b883a1416430ac0ebf0bc449bfc4091a'; | ||
| const SENTRY_API_SCHEMA_SHA = 'ee34d268ce4d0b03d8f35a25b607cf78e0567a23'; |
There was a problem hiding this comment.
Bug: The resolveOpenAPI function lacks error handling for failed fetch requests, causing a build failure if the OpenAPI schema URL returns a non-JSON response like a 404 page.
Severity: LOW
Suggested Fix
In resolveOpenAPI, check if response.ok is true before attempting to parse the JSON. If the response is not okay, throw an informative error to handle the failure gracefully instead of letting response.json() crash on invalid input.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/build/resolveOpenAPI.ts#L9
Potential issue: The `resolveOpenAPI` function fetches a schema from a raw GitHub URL
without validating the HTTP response. If the `SENTRY_API_SCHEMA_SHA` points to a
non-existent commit, GitHub will return a 404 HTML page. The code then attempts to parse
this HTML as JSON by calling `response.json()`, which will throw a `SyntaxError` and
cause the build process to fail. While CI/CD checks are expected to prevent an invalid
SHA from being merged, the lack of defensive error handling in the code itself presents
a latent vulnerability.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.