-
-
Notifications
You must be signed in to change notification settings - Fork 372
fix: Multiple attachments support for feedback #6459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6459 +/- ##
=======================================
Coverage ? 8.096%
=======================================
Files ? 419
Lines ? 29865
Branches ? 11745
=======================================
Hits ? 2418
Misses ? 27137
Partials ? 310
Continue to review full report in Codecov by Sentry.
|
|
(Closed and reopened this to retrigger workflows) |
@itaybre Apparently running workflows require manual approval |
📜 Description
Updated
SentryFeedbackto accept[Attachment]objects instead of raw[Data]arrays, enabling proper support formultiple attachments with full metadata (filename, content type, etc.).
This also introduces some breaking changes to public API:
initmethod signaturedataDictionary()method now returns attachments as[[String: Any]]with metadata instead of[Data]affecting consumers of theonSubmitSuccesscallbackThis issue originally came up in Unreal SDK while adding attachment support for user feedback:
💡 Motivation and Context
The previous implementation had several limitations:
attachmentsForEnvelope()assumed all attachments were screenshots and hardcoded filename: "screenshot.png" and contentType: "application/png"💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.