Additional ergonomic constructors (for Geometry and FeatureCollection)#271
Open
michaelkirk wants to merge 3 commits intomkirk/remove-json-methodsfrom
Open
Additional ergonomic constructors (for Geometry and FeatureCollection)#271michaelkirk wants to merge 3 commits intomkirk/remove-json-methodsfrom
michaelkirk wants to merge 3 commits intomkirk/remove-json-methodsfrom
Conversation
We have a lot of places where we build a GeometryValue and then convert it to a Geometry. Building the Geometry directly is a little cleaner.
I think it'll be easier for people to find FeatureCollection::new(features) rather than features.into_iter().collect();
Open
dabreegster
approved these changes
Feb 18, 2026
| } | ||
|
|
||
| impl FeatureCollection { | ||
| /// Construct a `FeatureCollection` from an iterator of Features (or things that can be turned `Into` a Feature) |
Contributor
There was a problem hiding this comment.
This is a very convenient new API :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Based on #270, so please review that first. If we decide not to merge #270, I can rebase this.
Like #265, but for
Geometry, notGeometryValue, and added aFeatureCollection::new(features)which I expect will be more discoverable thanfeatures.into_iter().collect::<FeatureCollection>().I also touched up the docs a bit.
This is a bit of a junk drawer polishing pull request. I could open a PR for each commit, but I think they're all pretty simple.