-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/refactor work in progress #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cliff76
wants to merge
18
commits into
georgeerol:master
Choose a base branch
from
cliff76:feature/RefactorWorkInProgress
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/refactor work in progress #7
cliff76
wants to merge
18
commits into
georgeerol:master
from
cliff76:feature/RefactorWorkInProgress
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Gets rid of example test. * Reverse left/right controls for consistancy with the UI. * Adds proper build support for Espresso. * Adds initial Spec/implementation for on-device BlueBotIDE. * Adds rough/ugly UI via TDD. * Adds basic code execution behavior to the IDE. * Adds generic request processing to UI instead of direct code execution to keep the UI thread free. * Adds response handler binding to the given RequestProcessor. * Adds basic response handling to the Activity. * Improves error handling. * Adds bluebotruntimelib w/ basic code runner. * Adds imposed line number ordering to BlueCode. * Adds feature to stop the bot after the final command & fixes broken tests. * Removes example unnecessary test. * Removes git tracking of project metadata. * Relocates RequestProcessor and ResponseHandler into the Java library. * Adds a multi-threaded CodeRunnerRequestProcessor which runs code in the background. * Cleans up concurrency code using Executor class. * Adds response handling to the CodeRunner. * Adds minor UI adjustments. (Still looks ugly.) * Connects the IDE activity to the main activity. * Wires everything together in a hacky way. * Upgrades android support version and extracts properties for version numbers. * Extracts strings for localization. * Removes globally shared bluetooth object from main activity and introduces shared components in the poor man's injection framework. * Addresses many issues from static analysis. *** Moves run button & error text to top of screen in IDE activity Adds view intent to allow Google app indexing/crawling inverts the name and semantics of the has() method on SharedComponents to doesNotHave() Removes redundant .gitignore entries Adds weaker scope to members marks other members as final addresses unchecked generics warnings Moves anonymous inner class to top level class. Throws Runtme exceptions when reflection instantiation of injection modules fail. Allows application full backup of content. Addresses certain methods with constant parameters by inlining. * Fixes the left/right signals in bluetooth codes. (They were originally backwards in the Arduino code and now they're fixed in both places.) * Adds autonomous mode toggle.
* add servo logic to arduino
* add travis file
* permission access for travis
* Update the BuildTools and SDK version for Travis CI
* Add jdk to travis.yml
* Change the Build tools to 19.1 and SDK to 22
* Change the Build tools to 25.0.2 and SDK to 25
* Add
- 'android-sdk-preview-license-.+'
- 'android-sdk-license-.+'
- 'google-gdk-license-.+'
* add new travis file
* add licenses to new travis file
* remove android 16 from the new travis file
* Add echo
* another new travis file
* don't know what im doing
* don't know what im doing
* don't know what im doing
* don't know what im doing
* don't know what im doing
* don't know what im doing
* don't know what im doing
* don't know what im doing
* don't know what im doing
* don't know what im doing
* Ignore test cases for now
Owner
|
Please resolve the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready for merge but you can give it a look. It's my original stab at refactoring. I think the other re-working we did together may still be on my iMac.