Open
Conversation
Author
|
It's now 2 weeks without feedback, is there anything I can do? @jessfraz maybe? |
Collaborator
|
ah dope can we change "create-date" to "created" and update the readme :) so sorry for the delay this is awesome :) |
This adds a '--sort' to the 'server' sub-command. Currently there is only one sort option, which is by create date. I assumed that his is useful in general, compared to a random order, so I made this the default. This is slightly over engineered, but makes it easier to add additional sorting options later. One that comes to my mind is sorting by tag (some kind of natsort/semversort). Signed-off-by: Roland Kammerer <roland.kammerer@linbit.com>
Author
|
Author
|
@jessfraz Time for another 2 weeks reminder :-). Anything else missing? |
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a '--sort' to the 'server' sub-command. Currently there is
only one sort option, which is by create date. I assumed that his is
useful in general, compared to a random order, so I made this the
default.
This is slightly over engineered, but makes it easier to add additional
sorting options later. One that comes to my mind is sorting by tag (some
kind of natsort/semversort).
Signed-off-by: Roland Kammerer roland.kammerer@linbit.com