Added VirtualCapacity to MachineClass NodeTemplate #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ialidzhikov <[email protected]>
Co-authored-by: Samarth Deyagond <[email protected]>
Signed-off-by: ialidzhikov <[email protected]>
* improve documentation * added make rule to generate api docs
* Fixed broken links * Fixed additional broken links
…ollout Scale down annotation value corrected
Signed-off-by: ialidzhikov <[email protected]>
Co-authored-by: Samarth Deyagond <[email protected]> Co-authored-by: Martin Weindel <[email protected]>
Co-authored-by: Ashwani Kumar <[email protected]> Co-authored-by: Ashwani Kumar <[email protected]>
Co-authored-by: Himanshu Sharma <[email protected]>
Signed-off-by: ialidzhikov <[email protected]>
…adm bootstrap` (#1004) * Add docs for running without target cluster * Handle disabled target cluster in manager/controller/test setup * Adapt `MachineDeployment` controller We skip any interaction with the target cluster by returning an error early if `InPlaceUpdate` is configured when running without a target cluster. `InPlaceUpdate` only works with a target cluster – `Node` metadata needs to be updated for it. Apart from that, there is no interaction with the target cluster in the `MachineDeployment` controller. * Adapt safety controller If running without a target cluster, we can entirely disable the SafetyAPIServer and Node controllers. Also, there is no need to annotate `Nodes` unmanaged by machine-controller-manager. * Adapt machine creation flow During machine creation, we never set the `node` label on the `Machine` to disable all interaction with the target cluster. With this, we skip waiting for the `Node` object to be registered. We also don't create any bootstrap tokens. Lastly, instead of tranisitioning to `Pending`, the `Machine` transitions to `Available` after creating the VM. * Adapt machine deletion flow If running without a target cluster, we skip drain and volume attachment logic and go straight to VM deletion. The `node` label does not exist, so we won't delete the `Node` object. * Extract `constants.TargetKubeconfigDisabledValue` * Move flag validation
gardener-robot
added
size/M
gardener-robot-ci-2
added
the
reviewed/ok-to-test
ghost
removed
the
reviewed/ok-to-test
gardener-robot
added
kind/api-change
ghost
added
the
reviewed/ok-to-test
gardener-robot
removed
the
size/M
ghost
removed
the
reviewed/ok-to-test
gardener-robot
added
size/M
gardener-robot-ci-2
added
the
reviewed/ok-to-test
ghost
removed
the
reviewed/ok-to-test
aaronfern
reviewed
Jul 14, 2025
| // Capacity contains subfields to track all node resources required to scale nodegroup from zero | ||
| Capacity corev1.ResourceList | ||
|
|
||
| // VirtualCapacity represents the expected Node 'virtual' capacity ie comprising virtual extended resources. |
Member
There was a problem hiding this comment.
nit
Suggested change
| // VirtualCapacity represents the expected Node 'virtual' capacity ie comprising virtual extended resources. | |
| // VirtualCapacity represents the expected Node 'virtual' capacity i.e comprising virtual extended resources. |
| virtualCapacityChanged = SyncVirtualCapacity(machineClass.NodeTemplate.VirtualCapacity, nodeCopy, lastAppliedVirtualCapacity) | ||
| } | ||
|
|
||
| if !annotationsChanged && !labelsChanged && !taintsChanged && !virtualCapacityChanged { |
Member
There was a problem hiding this comment.
You will have to consider initializedNodeAnnotation in this check here
As otherwise we could prematurely return and miss adding node.machine.sapcloud.io/last-applied-anno-labels-taints annotation to the node
Co-authored-by: Aaron Francis Fernandes <[email protected]>
gardener-robot-ci-1
added
the
reviewed/ok-to-test
|
@elankath You need rebase this pull request with latest master branch. Please check. |
gardener-robot
added
size/XL
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: