Skip to content

Conversation

@bgruening
Copy link
Member

Xmas cleanup :) 🎅

Xmas cleanup :) 🎅
bgruening added a commit to usegalaxy-eu/infrastructure-playbook that referenced this pull request Dec 20, 2025
@cat-bro
Copy link
Collaborator

cat-bro commented Dec 22, 2025

The smudgeplot rules need IDs too. If you rebase these 3 they will get better linting since you fixed that in the cat_bins PR.

@bgruening
Copy link
Member Author

I don't understand the linter output? Any idea whats wrong here?

@cat-bro
Copy link
Collaborator

cat-bro commented Dec 22, 2025

alphabetical order? I see a galaxyp tool between two devteams, and a couple of others. Running tpv format would sort these.

tools.yml Outdated
if: 15 <= input_size < 20
cores: 12
mem: 300
- id: tpvdb_smudgeplot_25_input_rule
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we can simplify these to Goldilocks style small, medium and large rules, and make the medium rule a calculation based on input_size? It looks like the medium rule would be something like:

    - id: tpvdb_smudgeplot_medium_input_rule
      if: 5 <= input_size < 20
      cores: 12
      mem: 75 + (input_size * 15)

@bgruening
Copy link
Member Author

Added the scaling rule and kept the failing rule. Thanks for the suggestion.

@bgruening
Copy link
Member Author

Thanks @cat-bro! I will merge to keep our config in sync, more PRs are coming :)

@bgruening bgruening merged commit c8e4881 into main Dec 24, 2025
1 check passed
@bgruening bgruening deleted the eu-additions branch December 24, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants