-
Notifications
You must be signed in to change notification settings - Fork 16
Add a few more tools from EU #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Xmas cleanup :) 🎅
|
The smudgeplot rules need IDs too. If you rebase these 3 they will get better linting since you fixed that in the cat_bins PR. |
|
I don't understand the linter output? Any idea whats wrong here? |
|
alphabetical order? I see a galaxyp tool between two devteams, and a couple of others. Running |
16c0b6e to
b852572
Compare
tools.yml
Outdated
| if: 15 <= input_size < 20 | ||
| cores: 12 | ||
| mem: 300 | ||
| - id: tpvdb_smudgeplot_25_input_rule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we can simplify these to Goldilocks style small, medium and large rules, and make the medium rule a calculation based on input_size? It looks like the medium rule would be something like:
- id: tpvdb_smudgeplot_medium_input_rule
if: 5 <= input_size < 20
cores: 12
mem: 75 + (input_size * 15)
Co-authored-by: cat-bro <[email protected]>
|
Added the scaling rule and kept the failing rule. Thanks for the suggestion. |
|
Thanks @cat-bro! I will merge to keep our config in sync, more PRs are coming :) |
Xmas cleanup :) 🎅