Refactor repository installation logic for efficiency and clarity #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Oct 15, 2025
mvdbeek
reviewed
Oct 15, 2025
mvdbeek
reviewed
Oct 15, 2025
Co-authored-by: Marius van den Beek <[email protected]>
…validated before processing installed repositories
mvdbeek
reviewed
Oct 15, 2025
… installed repositories
mvdbeek
reviewed
Oct 15, 2025
Member
mvdbeek
left a comment
mvdbeek
left a comment
There was a problem hiding this comment.
looks good now, if you restore the imports this is good to go
Co-authored-by: Marius van den Beek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the nested loop repository matching with a hash-based lookup table to improve performance and readability. Matching is now done via (name, owner, revision) keys with a secondary tool shed URL check. This reduces time complexity from O(n×m) to O(n+m) and simplifies the logic.