Skip to content

Use prop-types; don't use React.createClass (React 15.5) #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rsolomon wants to merge 2 commits into from
Closed

Use prop-types; don't use React.createClass (React 15.5) #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2ffaac
Use prop-types; don't use React.createClass
Apr 11, 2017
8d78a48
Add back displayName
Apr 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

var React = require('react'),
PropTypes = require('prop-types'),
withSideEffect = require('react-side-effect');

function reducePropsToState(propsList) {
Expand All @@ -17,13 +18,13 @@ function handleStateChangeOnClient(title) {
}
}

var DocumentTitle = React.createClass({
displayName: 'DocumentTitle',

propTypes: {
title: React.PropTypes.string.isRequired
},
function DocumentTitle() {
React.Component.call(this);
this.displayName = 'DocumentTitle';
}

DocumentTitle.prototype = Object.assign(Object.create(React.Component.prototype), {
Copy link
Contributor

@JaapRood JaapRood Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong, but Object.assign isn't supported in IE <= 11 according to MDN.

constructor: DocumentTitle,
render: function render() {
if (this.props.children) {
return React.Children.only(this.props.children);
Expand All @@ -33,6 +34,10 @@ var DocumentTitle = React.createClass({
}
});

DocumentTitle.propTypes = {
title: PropTypes.string.isRequired
};

module.exports = withSideEffect(
reducePropsToState,
handleStateChangeOnClient
Expand Down
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
"react": "^0.13.0"
},
"dependencies": {
"prop-types": "^15.5.0",
"react": "^15.5.0",
Copy link
Contributor

@JaapRood JaapRood Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure we wouldn't want to pull in our own copy of react here. Perhaps as a peer dependency?

"react-side-effect": "^1.0.2"
}
}