Skip to content

Conversation

@gallayl
Copy link
Collaborator

@gallayl gallayl commented Jan 25, 2026

🎭 Summary

  • Added user role management UI accessible from App Settings β†’ Identity β†’ Users
  • Expanded role system to support 4 roles: admin, media-manager, viewer, iot-manager
  • Each role has metadata (display name, description) for UI presentation
  • Users can be listed, viewed, and have roles edited by admins
  • Includes validation to ensure users always have at least one role

✨ Features

  • User List Page: Displays all users with their roles, creation date, and edit actions
  • User Details Page: View user info and manage roles with add/remove/restore functionality
  • RoleTag Component: Visual tag for roles with variant styles (default, added, removed)
  • UsersService: Frontend service with caching for user queries

πŸ”§ Infrastructure Changes

  • Improved Playwright config with better timeouts and CI serialization
  • Updated testing guidelines with user journey patterns and parallel test isolation
  • Added e2e/tsconfig.json for E2E test TypeScript configuration
  • ESLint config updated to use projectService instead of project

πŸ§ͺ Test Plan

  • Unit tests for UsersService (cache behavior, API calls, error handling)
  • Unit tests for UserListPage (rendering, navigation, retry)
  • Unit tests for UserDetailsPage (role editing, validation, save/cancel)
  • Unit tests for RoleTag component (variants, interactions)
  • Unit tests for role definitions
  • E2E test covering complete user management workflow
  • Verified existing E2E tests still pass

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2026

Bundle Report

Changes will decrease total bundle size by 18 bytes (-0.0%) ⬇️. This is within the configured threshold βœ…

Detailed changes
Bundle name Size Change
shades-showcase-app-esm 15.04MB -18 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: shades-showcase-app-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/monaco-*.js 359 bytes 4.97kB 7.78% ⚠️
assets/index-*.js 43 bytes 19.75kB 0.22%
assets/index-*.js 29 bytes 14.94kB 0.19%
assets/index-*.js -24.86kB 456.72kB -5.16%
assets/collection-*.js 9.34kB 12.05kB 343.52% ⚠️
assets/ai-*.js 33 bytes 9.82kB 0.34%
assets/media-*.js -156 bytes 6.86kB -2.22%
assets/user-*.js (New) 3.17kB 3.17kB 100.0% πŸš€
assets/user-*.js (New) 5.8kB 5.8kB 100.0% πŸš€
assets/app-*.js 601 bytes 4.33kB 16.13% ⚠️
assets/users-*.js 1.19kB 2.75kB 76.36% ⚠️
assets/users-*.js (New) 3.5kB 3.5kB 100.0% πŸš€
assets/iot-*.js 5 bytes 3.46kB 0.14%
assets/iot-*.js 5 bytes 2.41kB 0.21%
assets/drives-*.js 5 bytes 2.01kB 0.25%
assets/wizard-*.js 453 bytes 1.85kB 32.31% ⚠️
assets/movies-*.js 10 bytes 1.08kB 0.94%
assets/movie-*.js 10 bytes 1.03kB 0.98%
assets/modal-*.js (New) 441 bytes 441 bytes 100.0% πŸš€

Files in assets/user-*.js:

  • ./src/pages/admin/user-details.tsx β†’ Total Size: 12.0kB

Files in assets/app-*.js:

  • ./src/pages/admin/app-settings.tsx β†’ Total Size: 5.47kB

Files in assets/users-*.js:

  • ./src/components/role-tag/index.tsx β†’ Total Size: 2.66kB

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 20 lines in your changes missing coverage. Please review.
βœ… Project coverage is 40.22%. Comparing base (7500a58) to head (ed63cd9).

Files with missing lines Patch % Lines
frontend/src/components/role-tag/index.tsx 70.37% 8 Missing ⚠️
frontend/src/pages/admin/user-details.tsx 94.11% 3 Missing and 4 partials ⚠️
frontend/src/pages/admin/user-list.tsx 89.47% 4 Missing ⚠️
service/src/ai/actions/chat-action.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #104      +/-   ##
===========================================
+ Coverage    37.07%   40.22%   +3.14%     
===========================================
  Files          211      217       +6     
  Lines         3555     3774     +219     
  Branches       558      632      +74     
===========================================
+ Hits          1318     1518     +200     
- Misses        1990     2005      +15     
- Partials       247      251       +4     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gallayl gallayl enabled auto-merge (squash) January 25, 2026 10:50
@gallayl gallayl disabled auto-merge January 25, 2026 11:33
@gallayl gallayl enabled auto-merge (squash) January 25, 2026 13:36
@gallayl gallayl disabled auto-merge January 25, 2026 15:17
@gallayl gallayl merged commit 53b40a7 into develop Jan 26, 2026
9 of 10 checks passed
@gallayl gallayl deleted the feat/user-role-management branch January 26, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants