Skip to content

Conversation

@gallayl
Copy link
Collaborator

@gallayl gallayl commented Jan 18, 2026

🧪 Test Coverage Improvements

Adds unit test coverage for frontend components and services to improve code quality and prevent regressions.

✨ What's New

  • Component Tests (391 lines)

    • Icon component with multiple icon type support
    • Separator component rendering
    • Error404 page display and messaging
    • ThemeSwitch component with theme provider integration
  • Service Tests (1,472 lines)

    • DashboardService CRUD operations and caching
    • ErrorReporter GitHub issue creation
    • InstallService status checking
    • IotDevicesService device management and monitoring
    • LoggingService log entry management
    • MoviesService movie data operations
    • SeriesService series data operations

🎯 Coverage

  • All service tests include cache behavior verification
  • Observable pattern testing for reactive state
  • Proper resource disposal with usingAsync
  • Consistent mocking patterns across all tests

📊 Stats

  • Files Changed: 11 new test files
  • Lines Added: 1,863 lines
  • Test Cases: ~80+ test cases

@gallayl gallayl enabled auto-merge (squash) January 18, 2026 10:27
@gallayl gallayl merged commit 7500a58 into develop Jan 18, 2026
8 checks passed
@gallayl gallayl deleted the test/coverage-improvements-vol2 branch January 18, 2026 10:33
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.07%. Comparing base (de29af6) to head (c455c4a).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
frontend/src/services/iot-devices-service.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #103      +/-   ##
===========================================
+ Coverage    32.08%   37.07%   +4.98%     
===========================================
  Files          209      211       +2     
  Lines         3537     3555      +18     
  Branches       553      558       +5     
===========================================
+ Hits          1135     1318     +183     
+ Misses        2152     1990     -162     
+ Partials       250      247       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2026

Bundle Report

Changes will increase total bundle size by 143 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
shades-showcase-app-esm 15.04MB 143 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: shades-showcase-app-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 143 bytes 481.58kB 0.03%

Files in assets/index-*.js:

  • ./src/services/iot-devices-service.ts → Total Size: 6.2kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants