Skip to content

Conversation

@gallayl
Copy link
Collaborator

@gallayl gallayl commented Jan 18, 2026

🎯 Summary

  • Added new settings pages for IOT device availability and Ollama AI integration
  • Enhanced SettingsMenuItem to automatically detect active state from current URL using path-to-regexp
  • Removed manual isActive prop management from app-settings.tsx

✨ Changes

📡 IOT Settings Page

  • Configure ping interval and timeout for device availability checks
  • Form validation with min/max constraints
  • Persists configuration via ConfigService

🤖 AI Settings Page

  • Configure Ollama server host URL
  • Supports empty URL to disable AI features
  • URL validation (allows http/https only)

🧭 Navigation Improvements

  • SettingsMenuItem now automatically highlights based on current route
  • Uses LocationService.onLocationPathChanged for reactive URL detection
  • Simplified app-settings.tsx by removing manual active state tracking

🧪 Test Plan

  • Unit tests for IotSettingsPage (loading, rendering, save success/error)
  • Unit tests for AiSettingsPage (loading, rendering, save success/error)
  • Unit tests for SettingsMenuItem URL-based active detection
  • E2E tests for IOT settings form and save
  • E2E tests for AI settings form and save
  • E2E tests for navigation between all settings sections

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 86.36364% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.08%. Comparing base (5b64a7a) to head (72ef0a2).

Files with missing lines Patch % Lines
frontend/src/pages/admin/iot-settings.tsx 84.21% 9 Missing ⚠️
frontend/src/pages/admin/ai-settings.tsx 87.75% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #102      +/-   ##
===========================================
+ Coverage    30.38%   32.08%   +1.70%     
===========================================
  Files          207      209       +2     
  Lines         3429     3537     +108     
  Branches       525      553      +28     
===========================================
+ Hits          1042     1135      +93     
- Misses        2137     2152      +15     
  Partials       250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gallayl gallayl merged commit de29af6 into develop Jan 18, 2026
8 checks passed
@gallayl gallayl deleted the feat/extend-configuration branch January 18, 2026 10:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2026

Bundle Report

Changes will increase total bundle size by 6.79kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
shades-showcase-app-esm 15.04MB 6.79kB (0.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: shades-showcase-app-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 11 bytes 14.91kB 0.07%
assets/index-*.js 5 bytes 5.42kB 0.09%
assets/index-*.js -5 bytes 19.7kB -0.03%
assets/log-*.js -1 bytes 365.63kB -0.0%
assets/ai-*.js -7.15kB 2.64kB -73.04%
assets/ai-*.js (New) 9.79kB 9.79kB 100.0% 🚀
assets/app-*.js 683 bytes 3.73kB 22.44% ⚠️
assets/iot-*.js (New) 3.46kB 3.46kB 100.0% 🚀
assets/logging-*.js -5 bytes 1.87kB -0.27%

Files in assets/ai-*.js:

  • ./src/pages/admin/ai-settings.tsx → Total Size: 4.75kB

Files in assets/app-*.js:

  • ./src/components/settings-sidebar/settings-menu-item.tsx → Total Size: 1.67kB

  • ./src/pages/admin/app-settings.tsx → Total Size: 4.31kB

Files in assets/iot-*.js:

  • ./src/pages/admin/iot-settings.tsx → Total Size: 6.71kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants