Improve error handling and cleanup logic for benchmarks#813
Draft
zhixiangli wants to merge 3 commits intofsspec:mainfrom
Draft
Improve error handling and cleanup logic for benchmarks#813zhixiangli wants to merge 3 commits intofsspec:mainfrom
zhixiangli wants to merge 3 commits intofsspec:mainfrom
Conversation
- Introduced `_BENCHMARK_TYPE` substitution variable (defaults to "IO"). - Modified existing VM creation step (4a) to only run when type is "IO" (uses c4-standard-192). - Added new VM creation step (4b) for "METADATA" benchmarks (uses c4-standard-8). - Updated `run-benchmarks` to wait for both VM creation steps.
- Replaced `/workspace/failure` with `/workspace/FAILED` to track failing steps. - Added `_SKIP_IF_FAILED` check to skip benchmark execution if prior steps fail. - Added `allowFailure: true` to benchmark steps to ensure cleanup steps always run. - Updated cleanup steps (SSH key, VM, buckets) to only run if respective resources were initialized. - Added robust error reporting in the final step to list failed steps.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
==========================================
+ Coverage 79.55% 79.81% +0.26%
==========================================
Files 16 16
Lines 3042 3042
==========================================
+ Hits 2420 2428 +8
+ Misses 622 614 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasha26
reviewed
Apr 16, 2026
jasha26
reviewed
Apr 16, 2026
Collaborator
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error handling and cleanup logic for benchmarks. It depends on #810, and the diff will be clearer once #810 is merged.