add search to streams endpoint #919
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewvolz
commented
May 28, 2025
| } | ||
|
|
||
| export async function search(ctx: Context) { | ||
| ctx.cacheControl(ONE_HOUR) |
Member
Author
There was a problem hiding this comment.
Do we have an issue with caching with this endpoint? I'm seeing stale results on subsequent searches
Member
Author
There was a problem hiding this comment.
@copilot could you look into whether there are caching concerns with the way this pull request is changing things for a search endpoint?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
A client may want to pass in a custom date range, category, class (all/archived/upcoming), sort, offset in the future, though, but this does not have support for that