fix(Modal): use fixed positioning to avoid parent-dependent sizing#749
Merged
huyenltnguyen merged 1 commit intofreeCodeCamp:mainfrom Feb 9, 2026
Merged
fix(Modal): use fixed positioning to avoid parent-dependent sizing#749huyenltnguyen merged 1 commit intofreeCodeCamp:mainfrom
huyenltnguyen merged 1 commit intofreeCodeCamp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of the repo.#744 works but it causes Playwright failure:
https://github.com/freeCodeCamp/freeCodeCamp/actions/runs/21824605372/job/62967345618?pr=65786
This is because the internal
Dialogusesrelative w-full h-full, which can collapse when the portal parent has no explicit size.The fix is to change to
fixed inset-0:position: fixedremoves the Dialog from normal document flow and anchors it to the viewport (not its parent).inset: 0sets top/right/bottom/left: 0, so the Dialog exactly covers the viewport regardless of parent sizing or page scroll state.Screen recording (modal opens and closes correctly, without injecting scrollbars)
Screen.Recording.2026-02-10.at.01.15.30.mov