Draft
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
huyenltnguyen
force-pushed
the
feat/support-react-19
branch
from
74cc18d to
e3b31f9
Compare
huyenltnguyen
commented
Feb 11, 2026
Member
Author
There was a problem hiding this comment.
This is a temporary solution.
CI failed for the React 19 matrix because hook tests used @testing-library/react-hooks, which internally calls ReactDOM.render — a function removed in React 19. This caused TypeError: ReactDOM.render is not a function in tests.
Once /learn is upgraded to React 19. I'll update the library to drop support for older React versions and remove this test util.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of the repo.TODOs: