Skip to content

Conversation

@Sembauke
Copy link
Member

@Sembauke Sembauke commented Nov 24, 2025

Checklist:

The notes are simulated, they are actually send to the server but are not kept on the server and returned as one of the notes.

Notes by the user are only viewable locally and won't end up anywhere else.

@Sembauke Sembauke requested a review from a team November 24, 2025 12:24
…side functionality

- Created package.json for project dependencies and scripts
- Added static assets including an image (cats.jpg) and JavaScript files (main.js, form-handler.js)
- Implemented server.js to handle routes, serve HTML pages, and manage notes
- Developed client-side JavaScript to handle note creation and display
- Styled application with basic CSS for layout and notes display
@socket-security
Copy link

socket-security bot commented Nov 24, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednodemon@​3.1.109710010087100

View full report

@Sembauke Sembauke changed the title feat(services): add full-stack-open-notes-app service to docker-compose feat(curriculum): add full stack open note app Nov 25, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the random images in the weather proxy app, we have been keeping the images used for this on the cdn.

Is it integral to the learning outcomes for an image to be in the public/ folder to be served by the HTTP server?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want this project to be very similar to the original example project on Full Stack Open. So yes, the image should be in the public folder as the user can see how it is retrieved from the server.

For context: We want to host our own version of the project that does not send "offensive" messages to the server and storing them for others too see. My solution was to simulate sending messages to the server, and also simulating what you'd get back. While keeping the "real" notes the user made in local storage, this way we get the same effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants