-
Notifications
You must be signed in to change notification settings - Fork 100
feat(curriculum): add full stack open note app #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(curriculum): add full stack open note app #695
Conversation
…side functionality - Created package.json for project dependencies and scripts - Added static assets including an image (cats.jpg) and JavaScript files (main.js, form-handler.js) - Implemented server.js to handle routes, serve HTML pages, and manage notes - Developed client-side JavaScript to handle note creation and display - Styled application with basic CSS for layout and notes display
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the random images in the weather proxy app, we have been keeping the images used for this on the cdn.
Is it integral to the learning outcomes for an image to be in the public/ folder to be served by the HTTP server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want this project to be very similar to the original example project on Full Stack Open. So yes, the image should be in the public folder as the user can see how it is retrieved from the server.
For context: We want to host our own version of the project that does not send "offensive" messages to the server and storing them for others too see. My solution was to simulate sending messages to the server, and also simulating what you'd get back. While keeping the "real" notes the user made in local storage, this way we get the same effect.
Checklist:
Update index.md)The notes are simulated, they are actually send to the server but are not kept on the server and returned as one of the notes.
Notes by the user are only viewable locally and won't end up anywhere else.