fix: use api endpoint for snapshots data#110
Merged
chris-martin merged 4 commits intomainfrom Oct 27, 2025
Merged
Conversation
pbrisbin
requested review from
chris-martin and
mjgpy3
and removed request for
a team and
mjgpy3
Member
Author
|
The action tests will fail because they run using the latest release and not the code of this PR. |
Previously, we had a run of the action in the `test` job that used the built binary (`no-install`), then we had a run of the action in `test-action` (per os) that installed the latest release. The benefit here was that the run in `test` exercised a built binary in the context of the action, and the runs `test-action` exercised the install step on each os. The downside is that if there is a problem with the currently-released version (as there is right now), the `test-action` runs will fail. Since we have strict status checks on PRs, this makes it difficult to address that latest release. This commit addresses the downside while losing that upside: it makes the installation steps become untested. I think that's acceptable because the bulk of the logic is provided by a 3rd-party action (`pbrisbin/setup-tool-action`) which has its own test suite. Querying for "latest" is the only logic truly becoming untested (for now).
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Hmm. Maybe we rebrand EDIT: OK, I went with that approach. I think it's better. I'm not going to rename the job because I don't feel like pairing it with a GHVM PR to update the required statuses right now. |
This reverts commit dc75a78.
Running SLED in the context of an action is already tested as a step in the `test` job. `test-action` exists to test the (os-specific) installation steps, so it installs the latest release. Sometimes (as is the case now) there is a problem with that release which can cause `test-action` to fail. This can make it hard to merge the PR that is fixing things, since that status is required. By adding a `run` input and not actually running the tool in `test-action`, we can avoid this scenario by making the test only test what it cares about, and so be more robust to false failures like this.
chris-martin
approved these changes
Oct 27, 2025
Contributor
|
(Note: This is not yet released due to #111) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109.