feat: Initialize project (again) #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove row-types refactor: Slightly update some imports build: Update extra-deps in stack lts yamls Remove unsupported lts yamls style: Format CE JSON spec build: Fix Kafka client import docs: Flesh out readme some more feat: Simplify implementation, remove row-types
OlaoluwaM
requested review from
chris-martin,
derelbenkoenig,
jason-lieb,
joris974,
mjgpy3,
pbrisbin and
z0isch
OlaoluwaM
changed the title
mjgpy3
previously approved these changes
May 13, 2025
mjgpy3
left a comment
mjgpy3
left a comment
There was a problem hiding this comment.
LGTM. Really nice documentation throughout.
I could see us eventually splitting out different bindings into different packages (similarly how you'll see persistent for engine-agnostic stuff and persistent-postgresql for postgres-specific stuff).
Contributor
Author
|
@mjgpy3 that makes sense, I kinda just followed the structure in the JS SDK but I don't see why we couldn't split this out as you say |
|
@OlaoluwaM yeah and it's really not necessary to split at the moment. |
mjgpy3
previously approved these changes
May 13, 2025
chris-martin
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unofficial Haskell SDK for the cloudevents spec. Written with row types to allow for arbitrary extension attributes as per the spec requirements. This time without row-types.
This is a bare bones SDK that only allows for:
Currently only missing field deduplication