Conversation
The create_token method sends a form-encoded POST body but does not set the Content-Type header to application/x-www-form-urlencoded. Some OAuth servers (including AWS Cognito) return 405 Method Not Allowed when the header is absent because they cannot identify the request as a valid form POST. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Updates release version metadata and regenerates fragment.schema.json using the current schema sync process. Made-with: Cursor
Extends the OAuth request spec test to verify the token request uses application/x-www-form-urlencoded content type, aligned with RFC 6749 section 4.4.2 and its example request. Made-with: Cursor
Build the token request body with URI.encode_www_form to satisfy RFC 6749 section 4.4.2 / Appendix B UTF-8 form encoding requirements. Adds a test that verifies client_id and scope round-trip with special characters. Made-with: Cursor
sophiehouser
approved these changes
Mar 3, 2026
sophiehouser
left a comment
There was a problem hiding this comment.
i dont know anything about ruby but yolo approving!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Type: application/x-www-form-urlencodedassertion to OAuth spec testURI.encode_www_formper RFC 6749 §4.4.2 / Appendix Bscopeandclient_idNotes
Made with Cursor