Sequence Metadata w/ Arguments#30
Merged
zimri-leisher merged 10 commits intofprime-community:develfrom Apr 2, 2026
Merged
Conversation
…rime-community#26) Change Description Switch off of using the fprime-gds type API Split up the old types.py into state.py, visitors.py and dictionary.py New type system in types.py Add anonymous struct and array expressions, which can be used to skip calling type constructors Use struct/array field defaults from dictionary Fw.TimeInterval is an alias now for Fw.TimeIntervalValue Use FwTimeBase/ContextStoreType from the dictionary Properly load constants with enum values from the dictionary Allow trailing commas in param/arg lists, anon struct/arrays Properly handle more domain errors in model Breaking changes Fw.Time.timeBase now takes a TimeBase enum value Rename Fw.Time.time_context to timeContext, time_base to timeBase
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zimri-leisher
requested changes
Mar 23, 2026
Collaborator
|
@Lex-ari in order to help me review, can you please click "resolved" on any comments you have addressed? I think there are some that you haven't addressed too |
Collaborator
|
Here's a question: should we consider: like, can the user define a callable called |
Author
|
sequence should be a reserved word On second thought, we'll revisit |
| if not is_instance_compat(root_node, AstIdent): | ||
| # not a qualified name | ||
| # skip for now | ||
| if group == NameGroup.TYPE: |
Collaborator
There was a problem hiding this comment.
this was an existing bug. you could do x: 6 = 6 and it would crash the compiler
zimri-leisher
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Preliminary sequence argument addition to Fpy sequences.
This uses a high level definition to define metadata at the top of sequences, including arguments to sequences.
Rationale
As per customer request, Fpy sequences need support for in-place arguments that may be called from other Fpy sequences. This is the first step towards creating a specific "arg" keyword for use in Fpy sequences
Testing/Review Recommendations
Run pytest
Future Work