feat(config): add remappings_scope option for global remappings #13294
+106
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
remappings_scopeconfig option that controls whether dependency remappings are included when loading config. When set toglobal, only project-level remappings are used and remappings from nestedfoundry.tomlfiles in dependencies are ignored.This addresses the issue where Soldeer and similar package managers have dependencies that ship their own
remappings.txtfiles pointing tonode_modules/paths which don't exist in the project.Changes
RemappingsScopeenum (Default|Global) incrates/config/src/lib.rsremappings_scopefield toConfigstruct (default:Default)RemappingsProviderto skipfind_nested_foundry_remappings()when scope isGlobaltest_remappings_scope_global_ignores_dependency_remappingsUsage
With this config, remappings defined in
lib/dep/foundry.tomlare ignored, and only the project's remappings are used.Test Plan
remappings_scope = "global"Closes #12420