test(check.rb): distinguish between OMITTED and SKIPPED statuses #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Accidental operation... (Apparently, GitHub doesn't prevent the removal of a branch used by an open PR.) |
Replaced the test status "SKIPPED" with "OMITTED" when required conditions are not met. Also updated the colour mappings in the failure messages and detailed statistics for better visibility.
tueda
force-pushed
the
test-check-more-pretty
branch
from
3b565dc to
16ef803
Compare
Collaborator
Author
|
Rebased. |
Collaborator
|
This looks fine to go in, also for 4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the test results prettier.