Always use "multirun" mode for temp filenames #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some old TTP-specific code.
Also fix thread sort file names. "filenum" was omitted from the end due to length error in snprintf. Clean up and add commentary for filename buffer lengths.
Collaborator
Author
|
Rebased. |
Collaborator
Author
|
Should this one go into 4.3 also? It is not supposed to be a feature change that affects FORM users at all. But neither is it really a bug fix. |
Collaborator
|
I guess merging this PR into 4.3 won't impact typical users not doing anything special (like checking whether temporary files exist). But to be on the safe side, we could merge it only into 5.0 and skip 4.3 (until someone convinces us it must be included in 4.3 as well). |
This was referenced May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use "multirun" mode, to write the PID in the temporary file names. This makes FORM more robust by default, when running multiple jobs with the same FORMTMP/FORMTMPSORT directories.
Additionally use more digits of the PID in the name.