-
Notifications
You must be signed in to change notification settings - Fork 148
Tablebase readonly mode #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Currently, if you attempt to open a non-existing tablebase in readonly mode, there is no error and the file is created. I think this case should print an error and terminate FORM. |
|
Please have a look at the change. It should work now. |
|
Thanks, this works. Could you finally add test cases in You can run multiple form scripts in a single test case like this: jodavies@9a5e42d |
8860dda to
9f04338
Compare
|
I attempted to add two tests, but I think I don't entirely understand how the test framework works.... |
9f04338 to
096beb9
Compare
|
On my system, the parform valgrind error is also an error in form, but not so on the runner? Anyway, in |
096beb9 to
4f624b6
Compare
|
Done. |
4f624b6 to
d1b1f31
Compare
|
Ah, it seems #573 has broken the 32bit tests. |
|
On the master branch, even in 32-bit containers, Maybe rebasing will fix the CI failures? |
d1b1f31 to
a38d8dd
Compare
|
I think this looks good now. Any further comments, @tueda ? |
a38d8dd to
79e2b15
Compare
As suggested by @jodavies during the currently ongoing FORM workshop, I added an option
to the tablebase open command, allowing to open tablebases in read-only mode.
This allows to load tablebases in shared environments where not all users of the tablebases
have write permissions. In case the
addtocommand is called on a readonly tablebase file,an error is thrown and FORM terminates.
The syntax is simply:
TableBase "tablename.tbl" open, readonlySome documentation on this feature is also added to the relevant manual file.