Bump localstack image from 4.10.0 to s3-latest #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purpose localstack 4.10.0 is outdated. We need to be compatible with the latest AWS S3. Localstack 4.10.0 is very big resulting in long download time and high memory consumption. Approach Switch from 4.10.0 to s3-latest that is current and much smaller. localstack 4.10.0 image size: 432 MB - https://hub.docker.com/r/localstack/localstack/tags?name=4.10.0 localstack s3-latest image size: 106 MB - https://hub.docker.com/r/localstack/localstack/tags?name=s3-latest Pre-Merge Checklist: Before merging this PR, please go through the following list and take appropriate actions. - Does this PR meet or exceed the expected quality standards? - [x] Code coverage on new code is 80% or greater - [x] Duplications on new code is 3% or less - [x] There are no major code smells or security issues - Does this introduce breaking changes? - [x] There are no breaking changes in this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
localstack 4.10.0 is outdated. We need to be compatible with the latest AWS S3.
Localstack 4.10.0 is very big resulting in long download time and high memory consumption.
Approach
Switch from 4.10.0 to s3-latest that is current and much smaller.
localstack 4.10.0 image size: 432 MB - https://hub.docker.com/r/localstack/localstack/tags?name=4.10.0
localstack s3-latest image size: 106 MB - https://hub.docker.com/r/localstack/localstack/tags?name=s3-latest
Remove waitingFor, it's provided by testcontainers: https://github.com/testcontainers/testcontainers-java/blob/1.17.6/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java#L98
(Note: If testcontainer's waitingFor doesn't work properly bump testcontainers to a more recent version: https://github.com/testcontainers/testcontainers-java/blob/1.21.4/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java#L126 )
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.