-
Notifications
You must be signed in to change notification settings - Fork 39
Create TunableLabel for interactive frequency tuning #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduces the TunableLabel custom widget, enabling mouse wheel and click-based frequency adjustments in RigWidget. RigWidget now uses TunableLabel for freqLabel, handling tuneDeltaRequested signals to update frequency interactively. UI and project files updated to register and use the new component.
|
A try at #855 |
Updated include statements for TunableLabel in RigWidget.cpp, RigWidget.h, and RigWidget.ui to use the correct path 'ui/component/TunableLabel.h'. This resolves issues with locating the header file and ensures proper integration of the custom widget.
Changed the header path for the TunableLabel custom widget to use lowercase 'tunablelabel.h' for consistency and to avoid potential case-sensitivity issues on some filesystems.
Changed the Hz to MHz conversion to use 1000000.0 instead of 1'000'000.0 for compatibility with compilers that do not support digit separators.
Updated the include statement to use the correct relative path for tunablelabel.h, ensuring proper compilation and consistency with project structure.
|
Thanks. I also tried something similar but with already existing Is it possible that this is caused by my mouse, or what was the intended behavior? For my mouse, the Also, some of the comments in |
|
I was working on this with my laptop/trackpad and it was acting different than with my mouse. Sorry should have tested it there. I see on my mouse it takes a bit before it changes. I had the multipliers to try and follow what was in that request 1 then 500 then 2500. I'll spend some more time on it tonight. |
|
Michael, no problem. I'm using a very cheap HP mouse, so it's possible that it makes larger/smaller steps. I haven't tested the trackpad. |
|
not-tested my variant: |
Your patch works more consistently than mine. had to make one change. I know HamLib wants the frequency in Hz. I can cancel this PR since you already had a good solution. Rig::instance()->setFrequency(ui->freqLabel->value()*1000000); |
Introduces the TunableLabel custom widget, enabling mouse wheel and click-based frequency adjustments in RigWidget. RigWidget now uses TunableLabel for freqLabel, handling tuneDeltaRequested signals to update frequency interactively. UI and project files updated to register and use the new component.