[website] Remove usesCleartextTraffic#13117
Conversation
Summary of ChangesHello @mboetger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for configuring network security policies on Android. It removes an outdated and deprecated method for allowing cleartext traffic and introduces the modern, recommended approach using a network security configuration file. This ensures that developers follow current best practices for Android app development, improving security and maintainability of their applications. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to recommend using networkSecurityConfig instead of the deprecated usesCleartextTraffic for enabling cleartext HTTP connections in Android debug builds. The change is correct and follows modern Android development practices. I've added one suggestion to fix an incomplete XML tag in a code snippet to prevent potential copy-paste errors for users.
|
|
||
| ```xml | ||
| <application android:usesCleartextTraffic="true"/> | ||
| <application android:networkSecurityConfig="@xml/network_security_config"> |
There was a problem hiding this comment.
The XML snippet for the <application> tag is incomplete as it's not closed and contains a trailing space. This could cause confusion or errors if copied directly. To make it a valid and self-contained snippet, similar to the one it replaced, it should be a self-closing tag.
| <application android:networkSecurityConfig="@xml/network_security_config"> | |
| <application android:networkSecurityConfig="@xml/network_security_config" /> |
|
Visit the preview URL for this PR (updated for commit 3e8f258): https://flutter-docs-prod--pr13117-remove-usescleartexttraffic-29mxk0fk.web.app |
| ``` | ||
|
|
||
| Then, add the network configuration to your $project_path/android/app/src/debug/res/xml/network_security_config.xml: | ||
| ```xml |
There was a problem hiding this comment.
| ```xml | |
| Then, add the network configuration to your | |
| `<project_path>/android/app/src/debug/res/xml/network_security_config.xml`: | |
| ```xml |
| @@ -77,7 +77,19 @@ If you would like to allow HTTP connections for Android debug | |||
| builds, you can add the following snippet to your $project_path\android\app\src\debug\AndroidManifest.xml: | |||
There was a problem hiding this comment.
| builds, you can add the following snippet to your $project_path\android\app\src\debug\AndroidManifest.xml: | |
| builds, you can add the following snippet to your | |
| `<project_path>\android\app\src\debug\AndroidManifest.xml`: |
Removes deprecated usesCleartextTraffic.
Addresses: flutter/flutter#182553
Presubmit checklist
of 80 characters or fewer.