Skip to content

[various] Plugin Gradle pre-Kotlin standardization#11173

Open
stuartmorgan-g wants to merge 9 commits intoflutter:mainfrom
stuartmorgan-g:plugin-gradle-pre-conversion-standardization
Open

[various] Plugin Gradle pre-Kotlin standardization#11173
stuartmorgan-g wants to merge 9 commits intoflutter:mainfrom
stuartmorgan-g:plugin-gradle-pre-conversion-standardization

Conversation

@stuartmorgan-g
Copy link
Collaborator

As a precursor to converting plugins to use Kotlin Gradle build files in #11172, this does some final standardization of the Groovy versions:

  • Uses " instead of ' on more lines.
  • Uses (...) and = in places where it's optional, instead of just a space.
  • Uses minSdk instead of minSdkVersion.
  • Standardizes vertical whitespace (not necessary for the conversion, but it's something I cleaned up in that PR).

This is being done as a precursor PR because I noticed that the files are mostly right on the cusp of being similar enough for git to think they are renames with changes rather than deletion and addition; some are ending up one way, and some the other. Since renames with changes make blame much more useful, I'd like to make the files more similar so that hopefully almost all of them will end up as renames with changes in that PR.

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@stuartmorgan-g
Copy link
Collaborator Author

Version/changelog override: I'm intentionally not releasing these since the changes are no-ops in practice, and we'll be releasing all of these changes almost immediate afteward as part of #11172.

@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review March 3, 2026 20:16
@stuartmorgan-g
Copy link
Collaborator Author

@gmackall This just needs a quick rubber stamp to streamline the next PR in the conversion series.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a broad standardization of Groovy Gradle build files across numerous packages. The changes apply more modern Gradle DSL syntax, such as using double quotes, parentheses for method calls, the = for assignments, and updating properties like minSdkVersion to minSdk and lintOptions to lint, in preparation for a migration to Kotlin Gradle files.

The standardization appears to be incomplete for packages/local_auth/local_auth_android/android/build.gradle. This file still contains older syntax (e.g., single quotes for group and version, and method calls without parentheses) that has been updated in other files in this PR. Applying the standardization consistently to all files would better achieve the PR's stated goal.

@stuartmorgan-g
Copy link
Collaborator Author

The standardization appears to be incomplete for packages/local_auth/local_auth_android/android/build.gradle.

local_auth wasn't supposed to be included, to avoid conflicts with #11169. Reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant