Skip to content

[Many] Remove network policy from metadata#11165

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
mboetger:many-remove-metadata-network-policy
Mar 3, 2026
Merged

[Many] Remove network policy from metadata#11165
auto-submit[bot] merged 2 commits intoflutter:mainfrom
mboetger:many-remove-metadata-network-policy

Conversation

@mboetger
Copy link
Contributor

@mboetger mboetger commented Mar 3, 2026

It turns out the io.flutter.network-policy is not connected to the engine. Remove any mention of it.

Regardless, this should control dart sockets and these metadata tags are only added because of Espresso.

Addresses: flutter/flutter#183153

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@mboetger mboetger added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Mar 3, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the io.flutter.network-policy meta-data tag from the AndroidManifest.xml files in the example applications for the file_selector_android, image_picker_android, video_player_android, webview_flutter, and webview_flutter_android packages. This removal is applied to both debug and main manifest variants.

Note: Security Review has been skipped due to the limited scope of the PR.

@mboetger
Copy link
Contributor Author

mboetger commented Mar 3, 2026

Override changelog and version: configuration change of example apps.

@mboetger mboetger requested a review from stuartmorgan-g March 3, 2026 02:49
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2026

auto label is removed for flutter/packages/11165, Failed to merge flutter/packages/11165 with FormatException: Unexpected end of input (at character 1)

^
.

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026
@auto-submit auto-submit bot merged commit 03ed077 into flutter:main Mar 3, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 4, 2026
flutter/packages@9083bc9...82baf93

2026-03-04 louisehsu@google.com [camera_avfoundation] Fixes crash when
using ResolutionPreset.max with iPhone 17 (flutter/packages#11106)
2026-03-03 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Allow usage of all use cases concurrently
(flutter/packages#10732)
2026-03-03 matt.boetger@gmail.com [Many] Remove network policy from
metadata (flutter/packages#11165)
2026-03-03 matt.boetger@gmail.com [Espresso] remove metadata network
policy (flutter/packages#11164)
2026-03-03 stuartmorgan@google.com [tool] Add initial non-plugin package
support for Kotlin Gradle (flutter/packages#11127)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: file_selector p: image_picker p: video_player p: webview_flutter platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants