[Espresso] remove metadata network policy#11164
[Espresso] remove metadata network policy#11164auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request removes all references to the io.flutter.network-policy metadata tag. The documentation in README.md and the configuration in the example AndroidManifest.xml have been updated to remove it. The pubspec.yaml version is bumped to 0.4.0+23, and a corresponding entry has been added to CHANGELOG.md. My feedback focuses on improving the new changelog entry for clarity and fixing a minor formatting issue in the README.md.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM. Nice sleuthing!
|
auto label is removed for flutter/packages/11164, Failed to merge flutter/packages/11164 with FormatException: Unexpected end of input (at character 1) ^ |
It turns out the io.flutter.network-policy is not connected to the engine. Remove any mention of it. Regardless, this should control dart sockets and Espresso is only interested in Android native sockets.
Addresses: flutter/flutter#183153
Pre-Review Checklist
[shared_preferences]///).