Skip to content

[Espresso] remove metadata network policy#11164

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
mboetger:remove-io.flutter.network-policy
Mar 3, 2026
Merged

[Espresso] remove metadata network policy#11164
auto-submit[bot] merged 3 commits intoflutter:mainfrom
mboetger:remove-io.flutter.network-policy

Conversation

@mboetger
Copy link
Contributor

@mboetger mboetger commented Mar 3, 2026

It turns out the io.flutter.network-policy is not connected to the engine. Remove any mention of it. Regardless, this should control dart sockets and Espresso is only interested in Android native sockets.

Addresses: flutter/flutter#183153

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@mboetger mboetger requested a review from jesswrd as a code owner March 3, 2026 02:43
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes all references to the io.flutter.network-policy metadata tag. The documentation in README.md and the configuration in the example AndroidManifest.xml have been updated to remove it. The pubspec.yaml version is bumped to 0.4.0+23, and a corresponding entry has been added to CHANGELOG.md. My feedback focuses on improving the new changelog entry for clarity and fixing a minor formatting issue in the README.md.

mboetger and others added 2 commits March 2, 2026 18:53
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice sleuthing!

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2026

auto label is removed for flutter/packages/11164, Failed to merge flutter/packages/11164 with FormatException: Unexpected end of input (at character 1)

^
.

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026
@auto-submit auto-submit bot merged commit e5ef6e8 into flutter:main Mar 3, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: espresso platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants