[pigeon] Tidy imports and "ignore" comments#11149
Open
srawlins wants to merge 2 commits intoflutter:mainfrom
Open
[pigeon] Tidy imports and "ignore" comments#11149srawlins wants to merge 2 commits intoflutter:mainfrom
srawlins wants to merge 2 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Dart code generator for Pigeon. The changes include:
- Modifying the generated
ignore_for_filecomments to usetype=lint, which disables all lint rules for the generated files. - Removing the import of
Uint8Listfromdart:typed_datain generated files. - Changing the source of annotations (e.g.,
@immutable) from the Flutterfoundationlibrary to themetapackage.
These generator changes are reflected in the updated example and test files. The package version inpubspec.yaml,CHANGELOG.md, andgenerator_tools.darthas been updated to26.1.10.
Collaborator
We should make this something we can override internally for our own test generation; while we don't want to fail client analysis, we also don't want to introduce actual problems that lints would catch without our CI telling us. (E.g., if we leave out an |
Contributor
Author
|
That's a great idea! Is there one (or a few) cental spot where I could put a flag, for code generation "for/during tests"? Are there already tests that assert that new code doesn't have warnings or lints? Or is that mainly the checked-in code-generated files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uint8Listappears to be no longer needed.foundation.dartwas imported was for the annotations exported by the meta package.Pre-Review Checklist
[shared_preferences]///).