Skip to content

Rename 'Execution Log' to 'Execution Details' in presubmit view #5006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wadelhw wants to merge 1 commit into from
+6 −3
Closed

Rename 'Execution Log' to 'Execution Details' in presubmit view #5006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions dashboard/lib/views/presubmit_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import '../widgets/task_box.dart';

/// A detailed monitoring view for a specific Pull Request (PR) or commit SHA.
///
/// This view displays CI job statuses and execution logs.
/// This view displays CI job statuses and execution details.
final class PreSubmitView extends StatefulWidget {
const PreSubmitView({
super.key,
Expand Down Expand Up @@ -434,7 +434,7 @@ class _LogViewerPaneState extends State<_LogViewerPane> {
child: Row(
children: [
Text(
'Execution Log',
'Execution Details',
style: TextStyle(fontWeight: FontWeight.w600),
),
Spacer(),
Expand All @@ -457,7 +457,10 @@ class _LogViewerPaneState extends State<_LogViewerPane> {
width: double.infinity,
child: SingleChildScrollView(
child: Text(
selectedJob.summary ?? 'No log summary available',
selectedJob.summary
?? (selectedJob.status == 'Succeeded'
? '$jobName Executed Successfully. Click "View more details on LUCI UI" button below for more details.'
: 'No execution details available'),
style: const TextStyle(
fontFamily: 'monospace',
fontSize: 13,
Expand Down
Loading